1. Welcome! Please take a few seconds to create your free account to post threads, make some friends, remove a few ads while surfing and much more. ClutchFans has been bringing fans together to talk Houston Sports since 1996. Join us!

  2. ROCKETS GAMEDAY
    Just Dave flying solo tonight -- come join us for live postgame as the Rockets collapsed then came back to beat the Pelicans 107-105 Friday night!

    LIVE! ClutchFans on YouTube
Welcome ClutchFans Live

Javascript Help

Discussion in 'BBS Hangout' started by BMC, Apr 4, 2006.

Tags:
  1. BMC

    BMC Member

    Joined:
    Jan 16, 2001
    Messages:
    37
    Likes Received:
    0
    All,

    I am trying to write a small snippet of javascript to validate an email when entered on a form. I am at my wits end. Can someone tell me what is wrong with the code below?

    <html>

    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
    <title>New Page 1</title>

    <script language=javascript
    TYPE=text/javascript">

    function validEmail(email) {
    invalidChars = "/:;,"

    if (email == "") {
    return false
    }

    for (i=0 i<invalidChars.length;
    i++) {
    badChar = invalidChars.charAt(i)
    if (email.indexOf(badChar,0) >
    -1) {
    return false
    }
    }

    atPos = email.indexOf("@",1)
    if (atPos == -1) {
    return false
    }

    if (email.indexOf("@"+1) >
    -1) {
    return false
    }

    periodPos = email.indexOf(".",atPos)
    if periodPos == -1) {
    return false
    }

    if (periodPos+3 > email.length) {
    return false
    }

    return true
    }

    function submitIt() {

    alert("entering submitIt function")
    if {!validEmail(emailForm.email.value)) {
    alert ("Invalid email address");
    emailForm.email.focus()
    emailForm.email.select()
    return false
    }
    }

    </script>

    </head>

    <body>


    <form method="POST" action="mailto" onsubmit="return submitIt()">

    <p align="center"><b>
    <font size="2">
    Email:</font></b></p>

    <p align="center">
    <input name="email" type="text" maxlength="100" size="25" id="email" class="input" style="width:136;BORDER-RIGHT: 1px solid #0E1C23;
    BORDER-TOP: 1px solid #000000;
    FONT-SIZE: 10px;
    BORDER-LEFT: 1px solid #000000;
    COLOR: #000000;
    BORDER-BOTTOM: 1px solid #000000;
    FONT-FAMILY: Times;
    BACKGROUND-COLOR: #ffffff; height:17" /> </p>
    <p align="center">&nbsp;&nbsp;&nbsp;

    <input type="submit" value="Join" name="B1"></p>
    <p align="center">&nbsp;</p>
    </form>

    </body>

    </html>
     
    #1 BMC, Apr 4, 2006
  2. DrLudicrous

    DrLudicrous Member

    Joined:
    May 9, 2002
    Messages:
    3,936
    Likes Received:
    203
    Try this, I highlighted all the changes I made.

    Code:
    <html>

<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>New Page 1</title>


<script language="javascript" TYPE="text/javascript">

function validEmail(email) {
	invalidChars = "/:;,"

	if (email == "") {
		return false
	}

	for (i=0 [b];(change)[/b]i<invalidChars.length; i++) {
		badChar = invalidChars.charAt(i)
		if (email.indexOf(badChar,0) > -1) {
			return false
		}
	}

	atPos = email.indexOf("@",1)
	if (atPos == -1) {
		return false
	}

	if (email.indexOf("@"+1) > -1) {
		return false
	}

	periodPos = email.indexOf(".",atPos)
	if [b]((change)[/b]periodPos == -1) {
		return false
	}

	if (periodPos+3 > email.length) {
		return false
	}

	return true
}



function submitIt() {

	alert("entering submitIt function")
	if [b]((change)[/b]!validEmail([b]document.[/b]emailForm.email.value)) {
		alert ("Invalid email address");
		[b]document.[/b]emailForm.email.focus()
		[b]document.[/b]emailForm.email.select()
		return false
	}
}
</script>

</head>

<body>


<form method="POST" action="mailto" onsubmit="return submitIt();" [b]name="emailForm"[/b]>

<p align="center"><b>
<font size="2">
Email:</font></b></p>

<p align="center">
<input name="email" type="text" maxlength="100" size="25" id="email" class="input" style="width:136;BORDER-RIGHT: 1px solid #0E1C23;
BORDER-TOP: 1px solid #000000;
FONT-SIZE: 10px;
BORDER-LEFT: 1px solid #000000;
COLOR: #000000;
BORDER-BOTTOM: 1px solid #000000;
FONT-FAMILY: Times;
BACKGROUND-COLOR: #ffffff; height:17" /> </p>
<p align="center">&nbsp;&nbsp;&nbsp;

<input type="submit" value="Join" name="B1"></p>
<p align="center">&nbsp;</p>
</form>

</body>

</html>
     
    #2 DrLudicrous, Apr 4, 2006
  3. BMC

    BMC Member

    Joined:
    Jan 16, 2001
    Messages:
    37
    Likes Received:
    0
    Thanks Ludicrous but I dont think it is working. Maybe it is my browser? Nothing happens when I preview the code. I pasted your code in an html page all by itself and tested it. Did it work succesfully in your browser?
     
    #3 BMC, Apr 4, 2006
  4. DrLudicrous

    DrLudicrous Member

    Joined:
    May 9, 2002
    Messages:
    3,936
    Likes Received:
    203
    Yeah, make sure you take out the "(change)"s that I put in.
     
    #4 DrLudicrous, Apr 4, 2006
  5. SwoLy-D

    SwoLy-D Member

    Joined:
    Jul 20, 2001
    Messages:
    37,619
    Likes Received:
    1,460
    Use FireFox's JavaScript debugger... it will help so much...

    Several things I notice on your code:
    1. End ALL statements with a ";", including the one on the "onSubmit" action
    2. add a real action, not the "mailto" one. In fact, it's action="mailto:" instead.
    3. on an if-else statement, if there is only one action to follow after the condition, you don't need braces:
    if (mynick == "SwoLy-D")
    do_something();
    4. you might want to tell the browser WHAT version of JavaScript you're using... <script language="JavaScript1.2"> is better than what you have, so the browser doesn't get confused
    EDIT:
    5. the Invalid Chars list is best as an array, such as:
    var invalidChars = new Array(":","//");
    (don't forget that if you want to use the character / literally, you have to escape it with "//", since JavaScript thinks you will be making a comment
     
    #5 SwoLy-D, Apr 4, 2006
    Last edited: Apr 4, 2006
  6. BMC

    BMC Member

    Joined:
    Jan 16, 2001
    Messages:
    37
    Likes Received:
    0
    They fellas...I got it resolved. Sorry Ludicrous for not removing the (change) before retrying it.
     
    #6 BMC, Apr 4, 2006
  7. No Worries

    No Worries Wensleydale Only Fan
    Supporting Member

    Joined:
    Jun 30, 1999
    Messages:
    34,153
    Likes Received:
    22,491
    I have an unrelated JavaScript question:

    Does anybody have experience with any of these Ajax/DHTML JavaScript Libraries:

    Dojo Toolkit
    http://www.dojotoolkit.org/

    Ajax Toolbox
    http://www.javascripttoolbox.com/

    jQuery
    http://jquery.com/

    Moo.fx
    http://moofx.mad4milk.net/

    Prototype
    http://prototype.conio.net/

    Rico - Prototype derivative
    http://openrico.org/rico/home.page

    Sardalya
    http://www.sarmal.com/sardalya/Default.aspx

    Script.aculo.us - Prototype derivative
    http://script.aculo.us/

    Tacos (A-)
    http://tacos.sourceforge.net/index.html

    TurboWidgets
    http://turboajax.com/turbowidgets/

    TwinHelix
    http://www.twinhelix.com/

    Wicket
    http://wicket.sourceforge.net/

    Yahoo! User Interface Library
    http://developer.yahoo.com/yui/

    (I got this list from Ajax/DHTML Library Scorecard:How Cross Platform Are They?)

    My project is thinking seriously about switching from Sarissa (AJAX JavaScript llibrary) to a more robust Ajax/DHTML library. Prototype (or one its deriviatives) looks to be a good candidate?
     
    #7 No Worries, Apr 4, 2006
(You must log in or sign up to post here.)

Share This Page